FOUR-29250 End Event – External URL with Mustache/FEEL Support #1963
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description:
feat(end event): support Mustache in external URL for element destination
- Resolve Mustache expressions in end event "External URL" when the token
reaches the end event, using the same context as scripts/screens
(APP_URL, _request, _user, process variables).
- Add getElementDestinationMustacheContext() to build context via DataManager
with fallback; normalize to plain array for Mustache.
- Add resolveElementDestinationUrl() to decode HTML entities and render
URL template with MustacheExpressionEvaluator. FEEL is not supported.
- Apply resolution only for externalURL type; conditional redirect URLs
also go through Mustache when destination is external URL.
- Harden getElementDestinationAttribute(): ensure conditionalRedirectProp
and elementDestinationProp are never null (json_decode ?? [], pass ?? []).
- Modeler: allow URL validation when string contains {{ (Mustache); update
helper and error copy to document _request.id, _user.id, process vars.
Related tickets:
https://processmaker.atlassian.net/browse/FOUR-29250
modeler
|
||||||||||||||||||||||||||||||||||
| Project |
modeler
|
| Branch Review |
feature/FOUR-29250
|
| Run status |
|
| Run duration | 04m 11s |
| Commit |
|
| Committer | Roly Rudy Gutierrez Pinto |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
14
|
Skipped
|
0
|
Passing
|
191
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
StartTimerEvent.cy.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Start Timer Event > can set a specific end date |
Test Replay
Screenshots
|
|
The first 5 failed specs are shown, see all 73 specs in Cypress Cloud.
…pector to display element configuration data (formData) as key-value pairs with keyboard-accessible toggle.
|
rodriquelca
approved these changes
Feb 11, 2026
| return ''; | ||
| }, | ||
| isValidURL(string) { | ||
| if (!string || typeof string !== 'string') { |
Contributor
There was a problem hiding this comment.
null, undefined, 123, {}, [] will be valid for a isValidURL method
| return true; | ||
| } | ||
| // Allow Mustache: same context as backend (APP_URL, _request, _user, process variables) | ||
| if (string.includes('{{')) { |
Contributor
There was a problem hiding this comment.
"{{"
"{{invalid"
"hello {{"
will be evaluated as a valid value, try a regEx patern
example
const mustachePattern = /{{\s*[^}]+\s*}}/;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
feat(end event): support Mustache in external URL for element destination
Related tickets:
https://processmaker.atlassian.net/browse/FOUR-29250